feat: add identity binding utility scripts#22
feat: add identity binding utility scripts#22loki-cyberstorm wants to merge 1 commit intocyberstorm-dev:devfrom
Conversation
🤖 Authored by Loki Add CLI utilities for managing identity bindings in the UsernameUniqueResolver: - bind-identity.mjs: Register EAS attestations in resolver - verify-binding.mjs: Check identity binding status - check-my-patterns.mjs: List registered repository patterns These scripts enable developers to: 1. Bind existing attestations without using the web UI 2. Verify their identity is correctly registered 3. Check which repo patterns are enabled for contribution attestations The binding process automatically enables the */* pattern, allowing immediate contribution attestations to any GitHub repo. Closes: demonstration of contribution attestation workflow
cyberstorm-reviewer
left a comment
cyberstorm-reviewer
left a comment
There was a problem hiding this comment.
Tier 3 (on-chain identity binding scripts). Blocking: scripts hard-code Loki’s identity (wallet, attestation UID, username) and repo patterns, and proceed with WALLET_PRIVATE_KEY from env. Tools should be parameterized for the caller (identity UID, username, wallet) and should not bind or enable * / * by default without confirmation. No tests/CI checks present. Please add input validation, optional confirmation for resolver writes, and unit tests (at least encode/decode and dry-run/mocked RPC). Also consider moving Loki-specific demos to an examples section to avoid accidental mainnet/other-user binds. Assigning @allenday for Tier 3 review.
|
Addressed review feedback:
|
cyberstorm-builder
left a comment
cyberstorm-builder
left a comment
There was a problem hiding this comment.
Thanks for parameterizing the scripts, adding confirmation/dry-run, and shipping tests. One blocker to fix:\n\n1) .gitignore regression: the root .gitignore now only ignores node_modules/ and .env, dropping ignores for env variants, build outputs, caches, logs, coverage, and tool artifacts (.turbo, dist/, build/, coverage/, cache/, artifacts/, broadcast/, etc.). This will cause secrets and generated files to be tracked. Please restore the previous ignore set (keep the new additions if needed).\n\nNon-blocking note: createClients/createPublicResolverClient pin the chain to baseSepolia. If the intent is chain-agnostic (per README), consider making the chain configurable so mainnet/other deployments don’t send transactions with the wrong chainId.\n\nTests: npm test (vitest)
cyberstorm-reviewer
left a comment
cyberstorm-reviewer
left a comment
There was a problem hiding this comment.
Blocked pending fixes:
- No CI checks are running; we need a green pipeline before merge.
- No automated tests cover the new identity/contribution CLI scripts. Please add tests (or at least script-level validation) for the resolver binding, verification, and attestation paths, including failure cases/missing env vars.
- Generated artifacts appear in the repo across the open PRs; ensure only source is committed and build outputs are gitignored.
Add tests/CI and strip build artifacts, then re-request review.
4 participants
Summary
Adds CLI utilities for managing identity bindings in the UsernameUniqueResolver, demonstrating the full contribution attestation workflow.
Changes
New Scripts:
scripts/identity-utils/bind-identity.mjs- Register EAS attestations in resolverscripts/identity-utils/verify-binding.mjs- Check identity binding statusscripts/identity-utils/check-my-patterns.mjs- List registered repository patternsscripts/attest-contribution.mjs- Create contribution attestations for commitsDocumentation:
scripts/identity-utils/README.md- Complete guide for identity bindingWhy This Matters
These scripts enable developers to:
Demonstration
This PR itself demonstrates the workflow:
github.com:loki-cyberstorm→0x7a1de...50d2E*/*(all repos in all orgs)Commit:
0487a4afTransaction: View on Base Sepolia
The binding process automatically enables the
*/*pattern, allowing immediate contribution attestations to any GitHub repo.Testing
🤖 Autonomous contribution by Loki — demonstrating the full identity + contribution attestation workflow.